revert: switch back to LogoMenu from Custom Command Menu#294
revert: switch back to LogoMenu from Custom Command Menu#294dylanmtaylor wants to merge 1 commit intoprojectbluefin:mainfrom
Conversation
Restore logomenu@aryan_k as the panel menu extension. The Custom Command Menu swap needs to be coordinated with the bluefin Containerfile to land together. Ref: projectbluefin#222
dosubot
Bot
added
the
size:L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the custom-command-list extension with the Logo-menu extension, updating the enabled extensions list and providing default configurations. The review feedback highlights that the configuration is currently duplicated between a new dconf file and the gschema override file; it is recommended to consolidate these settings into the override file to maintain a single source of truth and avoid shadowing. Additionally, a comment describing the extension as using relocatable schemas was identified as inaccurate and should be corrected.
| [org.gnome.shell.extensions.Logo-menu] | ||
| symbolic-icon=true | ||
| menu-button-icon-image=30 | ||
| menu-button-terminal='xdg-terminal-exec' | ||
| menu-button-system-monitor='/usr/bin/missioncenter-helper' | ||
| menu-button-extensions-app='com.mattjakeman.ExtensionManager.desktop' | ||
| menu-button-software-center='/usr/bin/flatpak run io.github.kolunmi.Bazaar' | ||
| show-activities-button=true | ||
| show-lockscreen=false | ||
| show-power-option=false | ||
| show-gamemode=false | ||
| hide-forcequit=true | ||
| show-distroshelf=true |
There was a problem hiding this comment.
The configuration for the Logo-menu extension is duplicated between this override file and the newly added dconf file system_files/bluefin/etc/dconf/db/distro.d/04-bluefin-logomenu-extension. In GNOME, dconf database entries (compiled from distro.d) take precedence over GSettings overrides, meaning the entries here are effectively shadowed and will not take effect if they differ. To maintain a single source of truth and follow the repository's pattern for extension defaults, all settings should be consolidated here and the redundant dconf file should be removed. I have included the missing menu-button-icon-size key from the dconf file in the suggestion below.
[org.gnome.shell.extensions.Logo-menu]
symbolic-icon=true
menu-button-icon-image=30
menu-button-icon-size=20
menu-button-terminal='xdg-terminal-exec'
menu-button-system-monitor='/usr/bin/missioncenter-helper'
menu-button-extensions-app='com.mattjakeman.ExtensionManager.desktop'
menu-button-software-center='/usr/bin/flatpak run io.github.kolunmi.Bazaar'
show-activities-button=true
show-lockscreen=false
show-power-option=false
show-gamemode=false
hide-forcequit=true
show-distroshelf=true
| default-profile-uuid='2871e8027773ae74d6c87a5f659bbc74' | ||
|
|
||
| # Custom Command Menu commands are located in dconf | ||
| # LogoMenu extension uses relocatable schemas, so additional settings are in dconf |
There was a problem hiding this comment.
This comment is inaccurate. The Logo-menu extension uses a fixed schema ID (org.gnome.shell.extensions.Logo-menu), not a relocatable one. The presence of the configuration block at line 89 confirms it is a standard schema. This comment should be removed along with the redundant dconf file to ensure the configuration remains clear and maintainable.
1 participant
Restores
logomenu@aryan_kas the panel menu extension, backing out the Custom Command Menu swap from PRs #264, #272, and #274.The Custom Command Menu migration needs to be coordinated with the bluefin Containerfile (extension installation) to land as a single change. Bluefin already reverted to LogoMenu at the image level, so common needs to match.
Changes
04-bluefin-custom-command-menudconf file04-bluefin-logomenu-extensiondconf file (with updated Bazaar/missioncenter-helper paths)enabled-extensionsback tologomenu@aryan_kRef: #222